Companion hardware internal module continued

[elecpower]

Summary of changes:

• allow user the opportunity cancel hardware internal module update
• after hardware change, check and update all models internal module protocol to OFF if incompatible
• on model edit load, check and update model internal module protocol to OFF if incompatible
• fixed: do not allow radio settings to be edited whilst any models are in edit mode (requires internationalization testing)
• fixed: prevent multiple edit instances of same model (requires internationalization testing)
• fixed: destroy model edit dialog on close and reduce memory bloat
• fixed: change Edit Radio Settings to modal dialog

[pfeerick]

This is absolutely perfect! :)

• fixed: prevent multiple edit instances of same model (requires internationalization testing)

Since this seems to bring the open instance to focus, what needs testing? or am I confusing "internationalization testing" as I was thinking it was translations

Ready to merge? Seems to be working as expected for me.

[elecpower]

Internationalization is for translations - the code uses regexps to look for dialogs with matching window title. To truly test need someone running non-english language to test. If regexp doesn't work I will have to take a different tact.

[pfeerick]

oakey dokey... I'll switch languages and report back tomorrow ;)

[elecpower]

Internationalization is for translations - the code uses regexps to look for dialogs with matching window title. To truly test need someone running non-english language to test. If regexp doesn't work I will have to take a different tact.

Although this may not be a true test, switching the menu language to French is a test fail. Using menu language System Default on a French OS may work but I suspect the character sets screw with regexp even though the search string should be translated. So looks like another method required.

[elecpower]

Reworked to avoid translation issues

[pfeerick]

Looks good so far - with system languages French, German and Chinese in Windows 10, it worked perfectly. And also when using the menu to change the language back.

[pfeerick]

Any particular reason "Off" is not an option in Companion for Radio => Hardware settings (when it is on radio)? Also isn't a option for profile def internal module setting.

[elecpower]

Any particular reason "Off" is not an option in Companion for Radio => Hardware settings (when it is on radio)? Also isn't a option for profile def internal module setting.

Either @raphaelcoeffic or I erred. Anyway I'll sort out the shared list.