Remove calibration check when asserting availability of 6-pos switch positions#1368
Merged
Remove calibration check when asserting availability of 6-pos switch positions#1368
Conversation
Member
|
LGTM. I don't see a valid reason for the calibration state of the MULTIPOS to remove the positions from that switch. (i.e. such as 6POS). It by defintition has six discrete positions, even if the calibration is screwed (meaning the real issue is it needs calibrating properly). It would be like saying for the 3POS switches that a position is missing, when it is declared as a 3POS switch! |
pfeerick
approved these changes
Jan 11, 2022
Member
pfeerick
left a comment
pfeerick
left a comment
There was a problem hiding this comment.
LGTM. This means even if you have a calibrated 6POS you can at least pick the options. Obviously they won't work properly until you calibrate, but can't fix that problem!
pfeerick
pushed a commit
that referenced
this pull request
Jan 11, 2022
…positions (#1368) Thus allowing it to show on radio when calibration is invalid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, if your 6POS is not calibrated correctly, you cannot select anything but the first position in switch select drop-downs, because
isSwitchAvailable()verifies that the 6POS has the number of calibrated positions before letting you choose these positions, which is an issue in simulation, as you cannot really calibrate the 6POS properly.Further, I think it might be confusing to not be able to select a switch position just because the calibration is off.
Proposed change
This PR removes the check for calibrated positions.