Rotary encoder movement not to close throttle warning#1408
Merged
pfeerick merged 1 commit intoEdgeTX:mainfrom Jan 11, 2022
Merged
Rotary encoder movement not to close throttle warning#1408pfeerick merged 1 commit intoEdgeTX:mainfrom
pfeerick merged 1 commit intoEdgeTX:mainfrom
Conversation
pfeerick
approved these changes
Jan 11, 2022
Member
pfeerick
left a comment
pfeerick
left a comment
There was a problem hiding this comment.
Nice catch! Would have been an issue for other radios with rotary encoders also (i.e. X9D+2019 was also affected)
pfeerick
added
B&W
pfeerick
pushed a commit
that referenced
this pull request
Jan 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1407
Summary of changes:
Checking only key presses for closing throttle warning instead of any event.
This replicates the behavior for switch warning.