Merged
Conversation
raphaelcoeffic
approved these changes
Mar 17, 2022
pfeerick
approved these changes
Mar 18, 2022
Member
pfeerick
left a comment
pfeerick
left a comment
There was a problem hiding this comment.
Tested on X9D+2019... now uses a sensible number rather than garbage value. Curiously, OTX is using
https://github.com/opentx/opentx/blob/5c5076c84b057088a82bfae5393671d0c7e03ccd/radio/src/opentx.cpp#L286
which while is a variation of the original code here, also seems to also result in garbage values (on our codebase at least).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CPU_UID data stored from address 0x1FFF7A10 + 4 is on my radio
0x1FFF7A10+4 : 0x06, 0x51, 0x38, 0x31, 0x33, 0x37, 0x30, 0x33
Since the control character 0x06 (ACK) was mixed, I changed it to another character.
Looking at RM0090 39.1, it seems that the characters are stored from the lower byte of the UID, so the character storage order is set so that the upper byte comes first.