Skip to content

fix: Use setAvailableHandler to filter blMode menu#1798

Merged
pfeerick merged 1 commit intomainfrom
pfeerick/issue1795
Apr 5, 2022
Merged

fix: Use setAvailableHandler to filter blMode menu#1798
pfeerick merged 1 commit intomainfrom
pfeerick/issue1795

Conversation

@pfeerick
Copy link
Member

@pfeerick pfeerick commented Apr 3, 2022

Fixes #1795

Summary of changes:

  • use setAvailableHandler rather than string processing which also mangled some translations
  • this is colorlcd specific code, so doesn't need colorlocd conditional

Malte, since this was your handywork... :)

@pfeerick pfeerick requested a review from gagarinlg April 3, 2022 10:09
@pfeerick pfeerick added bug 🪲 Something isn't working color Related generally to color LCD radios labels Apr 3, 2022
@pfeerick pfeerick added this to the 2.7 milestone Apr 3, 2022
Copy link
Member

@raphaelcoeffic raphaelcoeffic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better now!

@gagarinlg
Copy link
Member

sorry, I missed the review request notification. This looks good to me.

@pfeerick
Copy link
Member Author

pfeerick commented Apr 5, 2022

No problem... it was mainly just to double check and make sure I didn't miss something else it was supposed to do.. I was going to ping you on Discord as well just in case but it was just one of the "didn't get there today... " days...

@pfeerick pfeerick merged commit ee5226b into main Apr 5, 2022
@pfeerick pfeerick deleted the pfeerick/issue1795 branch April 5, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🪲 Something isn't working color Related generally to color LCD radios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When the [SYS Menu] adjusts the backlight, the string is not truncated correctly.

3 participants