Companion option to insert if pasting onto existing model#1976
Merged
Companion option to insert if pasting onto existing model#1976
Conversation
elecpower
added
enhancement ✨
Member
|
Works great. Just some nits about the phrasing... Would it be better to have "Overwrite" instead of "Continue" (i.e. making the choices even more explicit)? I was trying to rephrase the dialog without it getting too curly - "Model already exists! Do you want to overwrite it or insert into a new slot?" - was about the best I could come up with... good/bad/ugly? Just some suggestions... it's perfectly fine to merge as is.
|
pfeerick
approved these changes
Jun 7, 2022
Collaborator
Author
|
Suggestions taken onboard and agree they are an improvement and as such a new commit has been added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1929
Summary of changes: