Skip to content

feat(telemetry): extend link quality warnings range#2251

Merged
pfeerick merged 3 commits intomainfrom
telemetry-warnings
Oct 12, 2022
Merged

feat(telemetry): extend link quality warnings range#2251
pfeerick merged 3 commits intomainfrom
telemetry-warnings

Conversation

@raphaelcoeffic
Copy link
Copy Markdown
Member

@raphaelcoeffic raphaelcoeffic commented Aug 30, 2022

This PR should allow to setup telemetry warnings in a useful way for protocols requiring higher warning values, such as ELRS / Crossfire where the link quality reported is actually a percentage.

Fixes #2205

Summary of changes:

  • extend warning values range to a full byte (from 6 bits).
  • moved disable bit to the others.

TODOs:

  • companion support
  • set useful default values (45/42 as per legacy)

@raphaelcoeffic raphaelcoeffic mentioned this pull request Aug 30, 2022
1 task
@pfeerick pfeerick added UX-UI Related to user experience (UX) or user interface (UI) behaviour telemetry 📶 labels Aug 30, 2022
@raphaelcoeffic raphaelcoeffic force-pushed the telemetry-warnings branch 2 times, most recently from 8e6a62e to cf021cb Compare September 1, 2022 04:37
@raphaelcoeffic raphaelcoeffic added this to the 2.8 milestone Oct 10, 2022
@pfeerick
Copy link
Copy Markdown
Member

Will play with in the morning, with a view to merge for nightly.

@pfeerick pfeerick self-assigned this Oct 11, 2022
@pfeerick
Copy link
Copy Markdown
Member

Triggered a rebase build due to a error I was getting in Companion, and unfotunately found out whilst waiting for that to build it was a bug elsewhere in Companion I hadn't run into before... so this missed the nightly. It's going into RC3 anyway 😆
image

@pfeerick pfeerick merged commit 6f494e1 into main Oct 12, 2022
@pfeerick pfeerick deleted the telemetry-warnings branch October 12, 2022 04:28
pfeerick pushed a commit that referenced this pull request Oct 12, 2022
* feat(telemetry): extend link quality warnings range

* Set default values to the old legacy FrSky values

* Companion support
ajjjjjjjj added a commit to OpenI6X/opentx that referenced this pull request Dec 28, 2025
ajjjjjjjj added a commit to OpenI6X/opentx that referenced this pull request Dec 28, 2025
* extend link quality warnings range (EdgeTX/edgetx#2251 port),
* model init refactor,
* Removed "Disabled RSSI alarm" warning (EdgeTX/edgetx#346 port)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

telemetry 📶 UX-UI Related to user experience (UX) or user interface (UI) behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Telemetry Alert Range

2 participants