Restore "go to channel monitor" Button

[eshifri]

Summary of changes:
This PR brings back the "go to channel monitor" button, that was present in 2.7.

I would not insist on it, but I think it has some use.
For the TXs with buttons it is not really necessary, since this functionality is available with MDL button, but for the buttonless radios I think it adds some convenience.

[pfeerick]

Personally think it was merely oversight - as you say it was a convenience for touch screen-only radios, and gave you the overview for all mixes and LS at any page.

[raphaelcoeffic]

May I suggest to have this only on radios that really do not have keys? Otherwise it might feel odd to not being able to access that button via encoder wheel.

[JimB40]

Not the best moment to bring it but I'd strongly advocate to have all-around-system quick shorcuts (for radios without keys available via quick-menu icons). If we can manage to make SYS,MDL & TELE configurable (eg long TELE can invoke Monitors) this will solve problem and benfit will be more UI space. Think in terms of 3.0

[pfeerick]

Indeed. That is off topic, and hopefully something for 2.9... but certainly won't be forgotten regardless... it's something I've wanted since I started with my TX16S and OTX ;)

[eshifri]

@raphaelcoeffic
This makes sense definitely.
Do we have a define for touch-only TXs?

[gagarinlg]

Do we have a define for touch-only TXs?

No, but for color LCD radios with Keys:
-DHARDWARE_KEYS

so
#if !defined(HARDWARE_KEYS)

should work

[eshifri]

@gagarinlg I do not think so: for NV14 HARDWARE_KEYS is defined as well. It is required to re-purpose trim buttons for ENTER/EXIT. Also without this definition events are not handled by onEvent().
So it looks like we need some other way to handle it.

[pfeerick]

So perhaps we need something that allows you to query if the TP is actually active/present in conjunction with HARDWARE_TOUCH? Which would probably be helpful for other parts of the code that just make assumptions based on the define.

[eshifri]

@raphaelcoeffic Actually, this button is accessible with the roller. (Eventually I got TX in my hands. :-) ).
So I think it can be displayed on all color targets. I think it makes sense: if user is using touch screen he can access channel monitor without going to buttons.

[pfeerick]

Oh, interesting... so it gets inserted between the last item on the mix list, and the options at the bottom in as far as how you get to it via scrolling... that works. I would probably have liked it to before the first mix / after the add mix button, but it does work. 🤷

[pfeerick]

Merging as it is accessible on non-touch only TXs ;)