fix(color): Deleting empty label caused EM/Hang#2392
Merged
pfeerick merged 2 commits intoEdgeTX:mainfrom Sep 28, 2022
Merged
Conversation
1 task
Member
|
Ouch! Yeah, sometimes a later check can come back to bite you! :) Prefered order is |
pfeerick
added
bug 🪲
1 task
pfeerick
changed the title
pfeerick
changed the title
pfeerick
pushed a commit
that referenced
this pull request
Oct 1, 2022
* If deleting a label, don't check size * If rename to blank, do nothing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2386
Looks like I introduced this with removing YAML characters to prevent unwanted characters in the Label. When deleting labels, it does a rename of all the models labels to "". There was a check that was preventing this action because size was zero..
Ooops.
Edit: Went into autopilot on the last PR.. Should be put into 2.8