Skip to content

[2.8] fix: FLASH overflow detection#3555

Merged
pfeerick merged 1 commit into
2.8from
2.8-fix-flash-overflow-detection
May 1, 2023
Merged

[2.8] fix: FLASH overflow detection#3555
pfeerick merged 1 commit into
2.8from
2.8-fix-flash-overflow-detection

Conversation

@raphaelcoeffic
Copy link
Copy Markdown
Member

Prior to this PR, FLASH overflow detection would fail if .text segment would be small enough, but the firmware would overflow once .data is added.

Summary of changes:

  • explicitly locate .data segment in FLASH instead of using _sidata marker.

Rather than using `_sidata` marker.
@raphaelcoeffic
Copy link
Copy Markdown
Member Author

Seems now we have the CI build failing at the proper place:

[100%] Linking CXX executable ../../firmware.elf
/opt/gcc-arm-none-eabi-10-2020-q4-major/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: ../../firmware.elf section `.data' will not fit in region `FLASH'
/opt/gcc-arm-none-eabi-10-2020-q4-major/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: region `FLASH' overflowed by 624 bytes
collect2: error: ld returned 1 exit status

We should have had this before, which now works properly: region 'FLASH' overflowed by 624 bytes

@raphaelcoeffic raphaelcoeffic changed the title fix: FLASH overflow detection [2.8] fix: FLASH overflow detection May 1, 2023
@pfeerick pfeerick added this to the 2.8.4 milestone May 1, 2023
@pfeerick pfeerick added bug 🪲 Something isn't working compilation Related to compiling the firmware and firmware options labels May 1, 2023
@pfeerick pfeerick merged commit 17e40f1 into 2.8 May 1, 2023
@raphaelcoeffic raphaelcoeffic deleted the 2.8-fix-flash-overflow-detection branch July 2, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🪲 Something isn't working compilation Related to compiling the firmware and firmware options

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants