feat: telemetry buffer for all internal modules#5267
Merged
Conversation
Collaborator
|
128 bytes ! Hurts, but needed I guess |
Member
Author
You don't cook omelette without breaking eggs 😇 |
Member
Hm... well, unless we were deciding that this is no longer a feature, it's not really an option but to lose some bytes... been nice knowing you, 128 bytes of SRAM 😆 You will be sorely missed I'm sure, especially on low SRAM transmitters! 🙃 |
Collaborator
|
I think we are all violently agreeing here :) |
pfeerick
pushed a commit
that referenced
this pull request
Jul 18, 2024
JunOllyLi
pushed a commit
to JunOllyLi/edgetx_muffin
that referenced
this pull request
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets which did not have support for CRSF or MULTI internal module (ex: X9D+ 2019, X7 ACCESS, NV14) would use a single telemetry buffer for internal and external module, thus causing clashes when 2 modules are used in parallel. This would for instance prevent using an external MPM as trainer module.
Please note that this will slightly increases memory usage for the targets mentioned above (up to 128 bytes).
Summary of changes: