Skip to content

fix: MPM disable telemetry user choice ignored#5286

Merged
pfeerick merged 1 commit into
mainfrom
3djc/fix-mpm-disable-telemetry
Jul 13, 2024
Merged

fix: MPM disable telemetry user choice ignored#5286
pfeerick merged 1 commit into
mainfrom
3djc/fix-mpm-disable-telemetry

Conversation

@3djc
Copy link
Copy Markdown
Collaborator

@3djc 3djc commented Jul 11, 2024

Fixes #5285

Summary of changes: overrides auto detection with user choice for MPM telemetry disabling

@raphaelcoeffic raphaelcoeffic added this to the 2.10.x milestone Jul 11, 2024
@raphaelcoeffic raphaelcoeffic added the bug/regression ↩️ A new version of EdgeTX broke something label Jul 12, 2024
@pfeerick
Copy link
Copy Markdown
Member

pfeerick commented Jul 13, 2024

Just a nitpick with the description as it was initially confusing... this PR isn't FrSky radio specific per se, but more "the Disable Telem GUI option will only be shown on Frsky radios, thus the bug that is being generally fixed will only be exposed on those radios (at this time)" ... unless of course you set the option manually in the model settings for some reason 🤷

@pfeerick pfeerick changed the title fix: MPM disable telem user choice ignored (FrSky radio only) fix: MPM disable telemetry user choice ignored Jul 13, 2024
@pfeerick pfeerick merged commit 2407212 into main Jul 13, 2024
@pfeerick pfeerick deleted the 3djc/fix-mpm-disable-telemetry branch July 13, 2024 01:53
pfeerick pushed a commit that referenced this pull request Jul 13, 2024
Option is currently only shown on FrSky radios, hence they are susceptible to this bug
JunOllyLi pushed a commit to JunOllyLi/edgetx_muffin that referenced this pull request Mar 28, 2026
Option is currently only shown on FrSky radios, hence they are susceptible to this bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug/regression ↩️ A new version of EdgeTX broke something

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Horus X10S Express: MPM switching off telemetry no longer works

3 participants