Conversation
Collaborator
|
I see no reason to keep. There are also lots of other if horus or taranis checks too. |
Collaborator
|
Would suggest holding back on any further work until qt6 is merged. |
Member
Author
|
Definitely - not putting any more effort into this until that is ready to go. Plus only intend to do baby step PRs / commits to make this easier to track. |
Probably pointless, but it was wrong anyway
pfeerick
force-pushed
the
pfeerick/cpn-die-sky9x
branch
from
b97a86c to
35012bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes:
FSIZE_corrections (was in fix(cpn): add HRS V14 #6409, move here as not strictly necessary there)WiP, some more optimisation / refactoring of some now otherwise redundant functions might still happen... ie. (IS_ARM() needs to go,
getReadFirmwareArgs()/getWriteFirmwareArgs()can probably be flattened... etc.@elecpower Any reason not to rip these out now (as in for 3.0, not necessarily right this instant 🤭)?