fix(libsimu): move Menu wrapper methods to fix Windows build#7015
Merged
fix(libsimu): move Menu wrapper methods to fix Windows build#7015
Conversation
pfeerick
added
simulator
bug/regression ↩️
Moving the inline wrapper method implementations for addLine() and addLineBuffered() from the header to menu.cpp resolves linker errors on Windows that appeared after PR #6989 moved other method implementations out of the header.
pfeerick
force-pushed
the
pfeerick/fix-cpn-dllexport
branch
from
85eb43d to
7125e04
Compare
pfeerick
changed the title
pfeerick
changed the title
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes compile error/failure when building libsim on Windows due to being broken by #6989 changes whereby inline wrapper methods were calling the non-inline methods across compilation unit boundaries on Windows.