fix(color): "gracefully" handles filechoice UI when too much file are present#7346
Closed
3djc wants to merge 3 commits into
Closed
fix(color): "gracefully" handles filechoice UI when too much file are present#73463djc wants to merge 3 commits into
3djc wants to merge 3 commits into
Conversation
Collaborator
|
Using LV_USE_LARGE_COORD would be better since it eliminates the problem altogether. Tested on TX16S Mk2 and it works without any obvious issues. One code change is required (in addition to setting LV_USE_LARGE_COORD to 1) setTop(max((coord_t)coords.y2 + 21, LCD_H - height())); |
Collaborator
Author
|
Alternative is in #7358. |
Member
|
Closing as #7358 fixes the underlying issue, and the rest is education / documentation related. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #7343
The heart of the issue is that the table holding the value exceeds the maximum coordinates accepted by LVGL in our current configuration.
This PR computes the number acceptable in a given hardware (screen resolution and layout does matter here).
If the number of files in a give choice exceed the limit, a too much file message is shown instead, and actual file number vs limits is also displayed in second line.
The alternative would be to move to LV_USE_LARGE_COORD accepting 32 bits coordinates, but the ripple effects of that would need to be understood.
NOT tested since I don't have a large enough sound list :D