moved getting git revision into xar target; removed expath template#63
Closed
daniel-jettka wants to merge 1 commit intoEdirom:developfrom
Closed
moved getting git revision into xar target; removed expath template#63daniel-jettka wants to merge 1 commit intoEdirom:developfrom
daniel-jettka wants to merge 1 commit intoEdirom:developfrom
Conversation
peterstadler
requested changes
May 10, 2021
Member
peterstadler
left a comment
peterstadler
left a comment
There was a problem hiding this comment.
Thanks for this PR. Yet, we need the file expath-pkg.xml for the EXPath packaging standard. In our build process, this was generated from the expath-pkg.xml.template file, so this should not be removed (at least without proper replacement).
Second, this looks like a "radical" approach in removing the <xmlproperty> completely. Have you tried a less invasive approach by only moving those properties into the target xar?
Author
|
Thanks for the review, that's been a rather bad shot then... :-) I'll check the suggestions and give it another try. |
daniel-jettka
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should resolve the issue with the necessary double build step