feat: add resource usage warnings for heavyweight commands#105
Merged
Miyamura80 merged 4 commits intomasterfrom Apr 2, 2026
Merged
feat: add resource usage warnings for heavyweight commands#105Miyamura80 merged 4 commits intomasterfrom
Miyamura80 merged 4 commits intomasterfrom
Conversation
Warn users about memory, CPU, and disk allocation before creating Docker containers, Tart VMs, or running test suites. Warnings are static and informational (no errors). Suppressible via --quiet/-q. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Greptile SummaryThis PR introduces static resource-usage warnings for heavyweight commands ( Key changes:
Issues found:
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
CLI["CLI invocation\n(--quiet flag)"] --> CMD{Command?}
CMD -- "run / attach / replay" --> ORC["orchestration::run_task"]
CMD -- "suite" --> SUITE["suite::run_suite"]
CMD -- "interactive" --> INT["interactive::run_interactive"]
CMD -- "init-macos" --> INIT["init_macos::run_init_macos"]
ORC --> Q1{quiet?}
Q1 -- No, Tart --> WT["warn_tart_resources()"]
Q1 -- No, Docker --> WD["warn_docker_resources(config)"]
Q1 -- No, Native --> SKIP1["(skip — no resources)"]
Q1 -- Yes --> SKIP1
SUITE --> Q2{quiet?}
Q2 -- No --> WS["warn_suite_resources(config, apps)"]
Q2 -- Yes --> IR
WS --> IR["inner_run { quiet: true }"]
IR --> ORC
INT --> Q3{step?}
Q3 -- No --> PAUSE["run_interactive_pause\nwarn_docker_resources()"]
Q3 -- Yes --> STEP["run_interactive_step\nwarn_docker_resources()"]
INIT --> Q4{quiet?}
Q4 -- No --> WI["warn_init_macos_resources()"]
Q4 -- Yes --> PROV["Provisioning"]
WI --> PROV
Reviews (3): Last reviewed commit: "🐛 Make suite warning platform-aware for..." | Re-trigger Greptile |
- Fix N+1 warning flood in suite mode: suppress per-test warnings when running inside a suite (suite-level summary is sufficient) - Fix misleading comment on DEFAULT_CPU_CORES constant Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
Suite warning now inspects task app types to show accurate resource info: Docker memory/CPU for Docker tests, disk usage for Tart VMs, and appropriate messaging for mixed or native-only suites. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
init-macosgolden image provisioning (~10-20 GB disk)--quiet/-qglobal flag to suppress these warningssrc/warnings.rsmodule with warning functions that read configured limits fromConfigTest plan
cargo buildpasses--quiet/-qflag appears in--helpoutputdesktest run task.jsonshows Docker resource warningdesktest run task.json -qsuppresses the warningdesktest suite ./testsshows aggregate suite warning🤖 Generated with Claude Code