Add more_details field and class average grade to grade data structure #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 'more_details' field to grade data structure and populated it from Edupage metadata.
Added class_grade_avg attribute to EduGrade and updated its assignment in the grade processing logic.
sveco86
changed the title
ivanhrabcak
requested changes
Oct 23, 2025
edupage_api/grades.py
Outdated
| except: | ||
| verbal = True | ||
|
|
||
| class_grade_avg = float(details.get("priemer")) |
Collaborator
There was a problem hiding this comment.
details.get("priemer") can be None, which could cause a TypeError
ivanhrabcak
approved these changes
Oct 23, 2025
Collaborator
ivanhrabcak
left a comment
ivanhrabcak
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 'more_details' field and "class average grade" to grade data structure and populated it from Edupage metadata.
requested in #91