Skip to content
This repository was archived by the owner on Aug 26, 2022. It is now read-only.

Conversation

@codygman
Copy link
Contributor

@codygman codygman commented Oct 13, 2021

https://app.shortcut.com/itprotv/story/96391/ensure-docker-stack-and-postgres-containers-use-the-same-versions


  • I manually tested the code locally to make sure that it works.
  • If there is documentation, I made sure it's accurate and up to date.
  • If possible, I wrote automated tests for the new behavior.

@codygman
Copy link
Contributor Author

Just tested this locally from smurf.

@codygman codygman requested review from a team and tfausak October 13, 2021 18:26
Copy link
Contributor

@tfausak tfausak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Seems like we should have done this when we upgraded the Postgres container in Smurf.

@codygman codygman merged commit 39ad9f6 into master Oct 13, 2021
@codygman codygman deleted the sc-96391-feature-ensure-docker-stack-and-postgres-containers branch October 13, 2021 20:19
@codygman
Copy link
Contributor Author

show it's correct

git log --oneline -n1
39ad9f6 Merge pull request #13 from EdutainmentLIVE/sc-96391-feature-ensure-docker-stack-and-postgres-containers

build the docker image

docker build -t itprotv/stack:2.7.3 .
fe0f4e1da3eb4d1106e105fedaee0cec

test that image has new psql

docker run -t itprotv/stack:2.7.3 psql --version
psql (PostgreSQL) 13.4 (Ubuntu 13.4-4.pgdg20.04+1)

push it

docker image push itprotv/stack:2.7.3

| The | push | refers | to | repository | [docker.io/itprotv/stack] |
| ffa2921fbf42: | Preparing | | | | |
| f7a8aa4e8b6d: | Preparing | | | | |
| 2decf15e038b: | Preparing | | | | |
| 87c5b3a62377: | Preparing | | | | |
| 4942a1abcbfa: | Preparing | | | | |
| ffa2921fbf42: | Layer | already | exists | | |
| 87c5b3a62377: | Layer | already | exists | | |
| 2decf15e038b: | Layer | already | exists | | |
| 4942a1abcbfa: | Layer | already | exists | | |
| f7a8aa4e8b6d: | Layer | already | exists | | |
| 2.7.3: | digest: | sha256:18c96d3d715dc2962e6c1f9fc25fd6d80e80d47eba6919f2002ab6ef9574a511 | size: | 1369 | |

@tfausak
Copy link
Contributor

tfausak commented Oct 13, 2021

For what it's worth, Docker Hub is configured to automatically build images when you push a tag to this repo. So if you didn't want to (or couldn't) build things locally, you can cut a new release to get Docker Hub to build it.

New release page: https://github.com/EdutainmentLIVE/docker-stack/releases/new
Docker Hub page: https://hub.docker.com/r/itprotv/stack/tags

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants