Merged
Conversation
Contributor
Author
|
These are the pylint errors that look concerning but as I don't know how to fix them, I leave this to you: |
Owner
|
This does appear to be a lot more than what I was asking for, as well as some large opinionated changes to the project that are not really proper etiquette to do without asking permission first. I was expecting only the following changes:
Because it's much larger, and you've left it to me to cherry pick, it will probably be a while before I get to it, and detangle what I want to include. |
Contributor
Author
eae5c34 to
0d7a6a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3
I got a bit distracted while trying to add the tests. Feel free to cherry-pick what you need.