Skip to content

Fix BlockIO issues#4

Merged
Eeems merged 2 commits intoEeems:mainfrom
mxmlnkn:develop
Jun 16, 2025
Merged

Fix BlockIO issues#4
Eeems merged 2 commits intoEeems:mainfrom
mxmlnkn:develop

Conversation

@mxmlnkn
Copy link
Copy Markdown
Contributor

@mxmlnkn mxmlnkn commented Jun 15, 2025

Closes #3

I got a bit distracted while trying to add the tests. Feel free to cherry-pick what you need.

@mxmlnkn
Copy link
Copy Markdown
Contributor Author

mxmlnkn commented Jun 15, 2025

These are the pylint errors that look concerning but as I don't know how to fix them, I leave this to you:

************* Module ext4.enum
ext4/enum.py:30:4: E1139: Invalid metaclass 'EnumerationType' used (invalid-metaclass)
************* Module ext4.inode
ext4/inode.py:152:19: E1120: No value for argument 'cls' in classmethod call (no-value-for-parameter)
************* Module ext4.xattr
ext4/xattr.py:47:20: E1120: No value for argument 'offset' in constructor call (no-value-for-parameter)
ext4/xattr.py:47:20: E1120: No value for argument 'size' in constructor call (no-value-for-parameter)
ext4/xattr.py:71:34: E0606: Possibly using variable 'value' before assignment (possibly-used-before-assignment)

@Eeems
Copy link
Copy Markdown
Owner

Eeems commented Jun 15, 2025

This does appear to be a lot more than what I was asking for, as well as some large opinionated changes to the project that are not really proper etiquette to do without asking permission first.

I was expecting only the following changes:

Because it's much larger, and you've left it to me to cherry pick, it will probably be a while before I get to it, and detangle what I want to include.

@mxmlnkn mxmlnkn changed the title Fix BlockIO issues and add tests Fix BlockIO issues Jun 15, 2025
@mxmlnkn
Copy link
Copy Markdown
Contributor Author

mxmlnkn commented Jun 15, 2025

I have extracted the bugfix for #3. I'll open another PR for the Python and dependency requirements, which I think are important. The rest of the dropped commits to expand the CI can be found here and may be cherry-picked.

@Eeems Eeems force-pushed the develop branch 7 times, most recently from eae5c34 to 0d7a6a3 Compare June 16, 2025 04:20
@Eeems Eeems merged commit 1f09da1 into Eeems:main Jun 16, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File objects seekable returns False even though they are seekable and seek returns None

2 participants