Make the generic type order consistent in the Left, Right, and Either#3650
Open
venusvavadiya wants to merge 4 commits intoEffect-TS:next-majorfrom
Open
Make the generic type order consistent in the Left, Right, and Either#3650venusvavadiya wants to merge 4 commits intoEffect-TS:next-majorfrom
Left, Right, and Either#3650venusvavadiya wants to merge 4 commits intoEffect-TS:next-majorfrom
Conversation
🦋 Changeset detectedLatest commit: 13e8e49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
987e88e to
7100817
Compare
Left, Right, and EitherLeft, Right, and Either
Member
|
Looks good but it's a breaking change so it would be for the next major |
Author
Thanks @mikearnaldi, I will add the necessary changeset. |
29a0e4a to
f69e0e1
Compare
6b92524 to
131b6fe
Compare
61bf528 to
eab3dbf
Compare
Author
|
Hello @mikearnaldi, I have added the changesets and also resolved the conflicts. I hope this is good to merge! Let me know if I missed anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
This PR makes the generic type order consistent between
Left,Right, andEither. It updatesLeft<L, R>andRight<L, R>toLeft<R, L>andRight<R, L>, respectively.