Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/beige-zoos-sell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@effect/cluster": patch
---

don't restart an entity during shutdown
31 changes: 18 additions & 13 deletions packages/cluster/src/internal/entityManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ export const make = Effect.fnUntraced(function*<
EntityAddress,
EntityState,
EntityNotAssignedToRunner
> = yield* ResourceMap.make(Effect.fnUntraced(function*(address) {
> = yield* ResourceMap.make(Effect.fnUntraced(function*(address: EntityAddress) {
if (yield* options.sharding.isShutdown) {
return yield* new EntityNotAssignedToRunner({ address })
}
Expand Down Expand Up @@ -246,30 +246,35 @@ export const make = Effect.fnUntraced(function*<
})
)

for (const id of defectRequestIds) {
const { lastSentChunk, message } = activeRequests.get(id)!
yield* server.write(0, {
...message.envelope,
id: RequestId(message.envelope.requestId),
tag: message.envelope.tag as any,
payload: new Request({
if (defectRequestIds.length > 0) {
for (const id of defectRequestIds) {
const { lastSentChunk, message } = activeRequests.get(id)!
yield* server.write(0, {
...message.envelope,
lastSentChunk
} as any) as any
})
id: RequestId(message.envelope.requestId),
tag: message.envelope.tag as any,
payload: new Request({
...message.envelope,
lastSentChunk
} as any) as any
})
}
defectRequestIds = []
}
defectRequestIds = []

return server.write
})
)

function onDefect(cause: Cause.Cause<never>): Effect.Effect<void> {
if (!activeServers.has(address.entityId)) {
return endLatch.open
}
const effect = writeRef.unsafeRebuild()
defectRequestIds = Array.from(activeRequests.keys())
return Effect.logError("Defect in entity, restarting", cause).pipe(
Effect.andThen(Effect.ignore(retryDriver.next(void 0))),
Effect.andThen(effect),
Effect.flatMap(() => activeServers.has(address.entityId) ? effect : endLatch.open),
Effect.annotateLogs({
module: "EntityManager",
address,
Expand Down
3 changes: 3 additions & 0 deletions packages/cluster/src/internal/resourceRef.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ export class ResourceRef<A, E = never> {
}).pipe(
Effect.andThen(this.acquire(scope)),
Effect.flatMap((value) => {
if (this.state.current._tag === "Closed") {
return Effect.interrupt
}
MutableRef.set(this.state, { _tag: "Acquired", scope, value })
return this.latch.open
})
Expand Down