fix(Match): handle null/undefined in Match.tag and Match.tagStartsWith#6018
Merged
tim-smart merged 1 commit intoEffect-TS:mainfrom Feb 3, 2026
Merged
Conversation
Add null checks to discriminator and discriminatorStartsWith predicates to prevent crashes when matching nullable union types. This follows the same pattern already used in discriminators (Match.tags). Fixes Effect-TS#6017
🦋 Changeset detectedLatest commit: 971727c The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
This follows my comment on #6017. The fix adds the same Minimal change - just 3 lines modified in the predicates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6017
Match.tagandMatch.tagStartsWithnow correctly handle nullable union types instead of crashing with "Cannot read properties of undefined (reading '_tag')".Problem
When using
Match.tagon a union type that includesnullorundefined, the predicate would crash because it accessed_[field]without first checking if_is nullish:Solution
Add
_ != null &&guard to the predicates indiscriminatoranddiscriminatorStartsWith, following the same pattern already used indiscriminators(which powersMatch.tags).Changes
packages/effect/src/internal/matcher.ts: Add null checks to predicatespackages/effect/test/Match.test.ts: Add test cases for nullable unionsTesting
Added 3 test cases:
Match.tagwithundefinedunionMatch.tagwithnullunionMatch.tagStartsWithwithundefinedunionAll 62 Match tests pass.