fix(cli): fix Prompt.text clear when input wraps terminal lines#6022
Merged
IMax153 merged 1 commit intoEffect-TS:mainfrom Feb 3, 2026
Merged
fix(cli): fix Prompt.text clear when input wraps terminal lines#6022IMax153 merged 1 commit intoEffect-TS:mainfrom
IMax153 merged 1 commit intoEffect-TS:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 2eeb3fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
When the user's input in `Prompt.text` exceeds the terminal width and wraps to a new line, `renderClearScreen` miscalculates lines to erase because it only considers `options.message`, not the full rendered line including the input value. This causes duplicate prompt lines to be printed on each keystroke after the text wraps. The fix calculates the full rendered line length: `"? " + message + " › " + inputValue` This is the same root cause as Effect-TS#5978 (for Prompt.select), and applies the equivalent fix to Prompt.text. Closes Effect-TS#5978
a7640b2 to
2eeb3fa
Compare
Member
|
Thanks @m9tdev ! Would you be willing to test the |
Member
Actually, nevermind. I think Tim's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the user's input in
Prompt.textexceeds the terminal width and wraps to a new line,renderClearScreenmiscalculates lines to erase because it only considersoptions.message, not the full rendered line including the input value.This causes duplicate prompt lines to be printed on each keystroke after the text wraps:
Root Cause
In
renderClearScreen, line erasure is calculated based only onoptions.message:But the actual rendered line includes:
"? " + message + " › " + inputValueFix
Calculate the full rendered line length:
Related
This is the same root cause as #5978 (for
Prompt.select), and applies the equivalent fix from #5979 toPrompt.text.Closes #5978