Skip to content

Backport PgClient.fromPool#6033

Merged
tim-smart merged 2 commits intomainfrom
EFF-411/pgclient-frompool
Feb 5, 2026
Merged

Backport PgClient.fromPool#6033
tim-smart merged 2 commits intomainfrom
EFF-411/pgclient-frompool

Conversation

@tim-smart
Copy link
Contributor

Adds PgClient.fromPool + PgClient.layerFromPool (ported from effect v4) so callers can build a PgClient from an externally-managed pg.Pool.

Also updates span attributes to use the derived connection config (so db.namespace / server.address are correct when connecting via url), and fixes workspace typechecking for pg-based test fixtures by declaring pg / @types/pg in the relevant packages.

Validation:

  • pnpm lint-fix OK
  • pnpm check OK
  • pnpm build OK
  • pnpm docgen OK
  • pnpm test run packages/sql-pg/test/Client.test.ts requires a container runtime (testcontainers) and fails in this environment

@github-project-automation github-project-automation bot moved this to Discussion Ongoing in PR Backlog Feb 5, 2026
@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2026

🦋 Changeset detected

Latest commit: b035382

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@effect/sql-pg Patch
@effect/cluster Patch
@effect/sql-drizzle Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/sql-clickhouse Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tim-smart tim-smart changed the title EFF-411 Backport PgClient.fromPool Backport PgClient.fromPool Feb 5, 2026
@tim-smart tim-smart linked an issue Feb 5, 2026 that may be closed by this pull request
@tim-smart tim-smart merged commit 740a912 into main Feb 5, 2026
11 checks passed
@github-project-automation github-project-automation bot moved this from Discussion Ongoing to Done in PR Backlog Feb 5, 2026
@tim-smart tim-smart deleted the EFF-411/pgclient-frompool branch February 5, 2026 05:49
@github-actions github-actions bot mentioned this pull request Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Allow passing a function as password to @effect/sql-pg

1 participant