Optimize getTypeAtLocation usage on non-expression nodes#490
Merged
mattiamanzati merged 1 commit intomainfrom Nov 13, 2025
Merged
Optimize getTypeAtLocation usage on non-expression nodes#490mattiamanzati merged 1 commit intomainfrom
mattiamanzati merged 1 commit intomainfrom
Conversation
This patch reduces unnecessary getTypeAtLocation calls by ensuring they are only performed on expression nodes, and adds additional null safety checks for symbol resolution. Changes: - LayerGraph: Only call getTypeAtLocation when node is an expression - TypeParser: Check node type before calling getTypeAtLocation in importedContextModule and importedDataModule - leakingRequirements: Add null check for aliased symbol - strictBooleanExpressions: Only check types for expression nodes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 9f42af9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This patch optimizes the language service by reducing unnecessary
getTypeAtLocationcalls and improving null safety in symbol resolution.Changes
getTypeAtLocationwhen node is an expression (addedts.isExpressioncheck)getTypeAtLocationinimportedContextModuleandimportedDataModulefunctionsPerformance Impact
By ensuring
getTypeAtLocationis only called on expression nodes, this reduces unnecessary type checker calls that could potentially be expensive or produce incorrect results.Test Plan
pnpm lint-fixcompletes without issuespnpm checkpasses TypeScript validationpnpm test- all 316 tests passing🤖 Generated with Claude Code