Correct histogram bucket values in metrics.mdx#1282
Merged
gcanti merged 1 commit intoEffect-TS:mainfrom Jan 22, 2026
Merged
Conversation
I'm not too familiar with effect but I think the comments explaining the histogram buckets are off. To get the count in a bucket between a range it looks like you would need to subtract the count in one bucket by the count in the previous bucket. So I believe this comment for example: // 20 values in the 30-40 range is over counting the amount of values in that range by listing the 2nd value in the [ 30, 20 ] array. Let me know if I'm misunderstanding something.
|
@jsfeldman is attempting to deploy a commit to the Effect Team on Vercel. A member of the Team first needs to authorize it. |
gcanti
approved these changes
Jan 22, 2026
Contributor
|
Thanks @jsfeldman |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not too familiar with effect but I think the comments explaining the histogram buckets are off. To get the count in a bucket between a range it looks like you would need to subtract the count in one bucket by the count in the previous bucket. So I believe this comment for example: // 20 values in the 30-40 range is over counting the amount of values in that range by listing the 2nd value in the [ 30, 20 ] array.
Let me know if I'm misunderstanding something.
Type
Description
Small update to the documentation relating to the count in each histogram bucket.
Related