fix: pass flow field in CreateUser and prevent NaN JSON crash#427
Merged
fix: pass flow field in CreateUser and prevent NaN JSON crash#427
Conversation
- CreateUser was missing the Flow parameter, causing VLESS users to be added without flow field, resulting in "account is not able to use the flow xtls-rprx-vision" errors - Add zero-division guard in bandwidthRecorder to prevent NaN when elapsed time is 0 - Add zero-division guard in metric_reader for CPU/memory/disk usage calculations to prevent NaN when total values are 0 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreateUser()was missing theFlowparameter, so VLESS users were added to xray without flow, causing"account is not able to use the flow xtls-rprx-vision"errorsbandwidthRecorderandmetric_readerproducedNaNfloat64 values, which causedjson: unsupported value: NaNfatal errors during config syncChanges
pkg/xray/user.go: Addflowparameter toCreateUser()and pass it fromsyncUserConfigsFromServer()pkg/xray/bandwidth_recorder.go: Guardelapsed > 0before bandwidth divisionpkg/metric_reader/node.go: Guard zero total values before CPU/memory/disk usage percentage calculationsTest plan
go build ./...passes🤖 Generated with Claude Code