fix(Snackbar): add aria-hidden to empty snackbar position regions#1124
Merged
ychhabra-eightfold merged 2 commits intoMay 5, 2026
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
ychhabra-eightfold
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY:
For ENG-192648:-
Problem:-Too many announcements of notifications - On this page, screen reader announces “Notifications region” multiple times which is confusing to the reader.
Solution:- Fix the notification region issue through aria-hidden true.
For ENG-192652:-
Problem:- Screen Reader Focuses and Announces “Notification Region” Multiple Times Without Context.
Occurs across all screens after the Get Help button in the footer.
When navigating with the Down Arrow key after the Get Help button:
• The term “Notification region” is focused and announced multiple times by the screen reader.
• No visible notifications are present, and the purpose of this region is unclear.
• This behavior is misleading and disrupts navigation for screen reader users.
Repeated focus and announcement of an unexplained region creates confusion, increases cognitive load, and negatively affects accessibility.
Solution:- Fix the notification region issue through aria-hidden true.
GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-192648
https://eightfoldai.atlassian.net/browse/ENG-192652
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
SnackbarContainersetsaria-hidden="true"on any of the 6 positionrole="region"divs that have no active snacks, and removes it when a snack is present.All 6 regions on initial render | Every
[role="region"]hasaria-hidden="true"Screen.Recording.2026-04-27.at.12.07.37.AM.mov
Screen.Recording.2026-04-26.at.11.05.49.PM.mov