Merged
Conversation
… navigate it to homescreen. Will you please see that and tell me what I have to do to correct that. And I will do that also so please don't it assign to anyone
…y change is need please let me know
1 Make SVG from alphabets page theme adaptive to resolve this I gave the conatiner again its color. That was not there in your reverted PR 2 Make the Ui better 3 Now the square boder line is not coming in pop up screen
… boder radius is not coming now, change the UI and Now i had gave the pop up screen its color instead of transparent so the image issue will not come.
… solve that image issue to, made the screen flexible
…m due to dark background, removed rectangle from pop up, changes the UI
Contributor
Author
|
@sapatevaibhav will you please tell me what I have to do to ressolve the conflicts |
Collaborator
No need to worry I'll do it. |
Contributor
Author
|
@sapatevaibhav Thank you so much |
sapatevaibhav
added
the
Under Review 👀
sapatevaibhav
approved these changes
May 12, 2024
Collaborator
|
Just do not touch some code like AppConstants and from now on use as it was and add your data there... |
This was referenced May 12, 2024
Closed
sapatevaibhav
removed
the
Under Review 👀
sapatevaibhav
added
gssoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the UI, Solved the problem of not flexible with different screen sizes, image problem solved in dark background, removed the rectangle that was coming in background