Conversation
- Update DEFAULT_VITE_VERSION to ^8.0.0 in version.rb - Update vite devDependency to ^8.0.0 in both plugin packages - Update TypeScript to ^5.0.0 and @types/node to ^22.0.0 for Vite 8 compatibility - Switch moduleResolution from Node to Bundler in tsconfig (Vite 8 dropped main field in favor of exports map) - Update example packages: @vitejs/plugin-legacy to ^8.0.0, @vitejs/plugin-vue to ^6.0.0, sass to ^1.70.0 - Update build test snapshots and expected filenames for Rolldown-generated hashes - Fix dev_server_proxy_test.rb to use lambda directly instead of Rack::Builder#run return value (Rack 3.2.5 changed this to return nil) - Vite 8 requires Node >=20.19.0 or >=22.12.0 (tested with Node 22.22.1) - Existing rolldown detection in index.ts (this.meta.rolldownVersion) works correctly with Vite 8 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ElMassimo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
^8.0.0inDEFAULT_VITE_VERSIONthis.meta.rolldownVersioninindex.ts) works correctly out of the box^5.0.0and switchesmoduleResolutionfromNodetoBundler(Vite 8 dropped themainfield in favor ofexportsmap, requiring modern TS module resolution)@types/nodeto^22.0.0and example deps (@vitejs/plugin-legacy ^8.0.0,@vitejs/plugin-vue ^6.0.0,sass ^1.70.0) to versions compatible with Vite 8dev_server_proxy_test.rb:Rack::Builder#runnow returnsnilin Rack 3.2.5 (it previously returned the app as an unintended side effect), so the test now creates the capture lambda directlyNotes
>=20.19.0or>=22.12.0(tested with Node 22.22.1)>=5.0.0to allow gradual adoptionTest plan
pnpm -C vite-plugin-ruby build— passespnpm -C vite-plugin-ruby test— 9 tests passpnpm -C vite-plugin-rails build— passespnpm -C vite-plugin-rails test— 2 tests pass (snapshot regenerated)bundle exec rake test— 98 tests, 0 failures, 0 errorsvite-plugin-ruby/examplebuild — passesvite-plugin-rails/examplebuild — passes🤖 Generated with Claude Code