Skip to content

Ch increase test coverage 162106573#25

Merged
ElMonstro merged 2 commits intodevelopfrom
ch-increase-test-coverage-162106573
Nov 21, 2018
Merged

Ch increase test coverage 162106573#25
ElMonstro merged 2 commits intodevelopfrom
ch-increase-test-coverage-162106573

Conversation

@ElMonstro
Copy link
Owner

@ElMonstro ElMonstro commented Nov 21, 2018

What does this PR do?
Adds tests for edge cases

Description of Task to be completed?

  • Add tests for edge cases

How should this be manually tested?

  • clone repo into a local directory
  • git clone --single-branch -b ch-increase-test-coverage-162106573 https://github.com/ElMonstro/SendIT-API.git
  • Install postgres database
  • Create database test_db
  • Export the database URL to the environment with key 'DB_URL'
  • Install virtualenv, create a virtual environment and activate it
  • cd into root project directory
  • run the command pip3 install -r requirements.txt
  • Create orders and then run pytest

What are the relevant pivotal tracker stories?
https://www.pivotaltracker.com/story/show/162106573

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 0c45974 and detected 8 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 8

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 98.7% (10.0% change).

View more on Code Climate.

@codecov
Copy link

codecov bot commented Nov 21, 2018

Codecov Report

Merging #25 into develop will increase coverage by 11.69%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop      #25       +/-   ##
============================================
+ Coverage    85.58%   97.27%   +11.69%     
============================================
  Files           16       15        -1     
  Lines          867      808       -59     
  Branches       119      109       -10     
============================================
+ Hits           742      786       +44     
+ Misses          99       10       -89     
+ Partials        26       12       -14
Impacted Files Coverage Δ
app/api/v1/models.py 95.45% <ø> (+5.56%) ⬆️
app/db_config.py 100% <ø> (+7.69%) ⬆️
app/api/v2/views/order_views.py 97.46% <100%> (+17.72%) ⬆️
app/api/v2/models/order_models.py 98.59% <100%> (+8.71%) ⬆️
app/api/v2/models/user_models.py 88.88% <100%> (+23.88%) ⬆️
app/api/v2/utils/validators.py 100% <0%> (+10%) ⬆️
app/api/v2/views/auth_views.py 94.66% <0%> (+13.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65286e4...0c45974. Read the comment docs.

@coveralls
Copy link

coveralls commented Nov 21, 2018

Pull Request Test Coverage Report for Build 123

  • 12 of 12 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+11.2%) to 97.885%

Files with Coverage Reduction New Missed Lines %
app/api/v2/models/user_models.py 1 89.66%
Totals Coverage Status
Change from base Build 121: 11.2%
Covered Lines: 812
Relevant Lines: 822

💛 - Coveralls

@ElMonstro ElMonstro merged commit 7b5aa69 into develop Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants