Skip to content

Commit ffbe9c7

Browse files
SashaMITcursoragent
andcommitted
ci(smoke-test): promote linux-arm64 from experimental to required gate
linux-arm64 has now had 5 consecutive green runs since being added to the matrix in A-3 (matrix expansion): 25947219129 (A-3 introduction) β†’ success 25947614795 (cross-env) β†’ success 25955832357 (test:unit dir path) β†’ success 25956072211 (CRLF normalisation) β†’ success 25956409080 (rollback dry-run docs) β†’ success The promotion criterion documented in the workflow comment ("5 consecutive green runs without revert") is met. Concrete change: - matrix entry experimental: true β†’ false - continue-on-error: ${{ matrix.experimental }} now resolves to false for this entry, meaning a red linux-arm64 build will fail the Smoke test summary job Rationale: the linux-arm64 launcher rollout follows the Mac launcher release window; tightening the safety net now (before any ARM- specific code lands) gives us earlier warning of platform- specific regressions. windows-x64 remains experimental: it only had 1-2 consecutive greens after recovering from a string of platform-specific blockers yesterday (env-var-prefix syntax, node --test glob expansion, CRLF in test scanner). Needs ~3 more clean runs before promotion. Comment in the matrix entry documents the next-likely blocker (build:gui cp -r command) so whoever promotes it next knows where to look. Header comment in the workflow file also updated to reflect the new gate status. No behavioural change for the existing required gates (linux-x64, darwin-arm64). Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent f1c3b4a commit ffbe9c7

1 file changed

Lines changed: 29 additions & 32 deletions

File tree

β€Ž.github/workflows/smoke-test.ymlβ€Ž

Lines changed: 29 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ name: Smoke test (build + boot)
2121
# - Any dependency / workspace install break (the v1.2.7.x lockfile drift class)
2222
# - v1.2.7.11 osascript apostrophe regression (via test:unit step)
2323
#
24-
# Phase 5 (A-3, this revision): matrix expansion to ubuntu-24.04-arm +
25-
# windows-latest as experimental gates that surface platform-specific
26-
# regressions ahead of the Linux-ARM / Windows launcher rollout that
27-
# follows the Mac launcher. These DO NOT block release tagging until
28-
# proven stable; see continue-on-error on the matrix.
24+
# Phase 5 (A-3, A-3.1): matrix expansion to ubuntu-24.04-arm +
25+
# windows-latest. linux-arm64 promoted to required gate 2026-05-16
26+
# after 5 consecutive green runs since matrix introduction. windows-x64
27+
# remains experimental until it has the same green streak; see
28+
# continue-on-error on the matrix.
2929
#
3030
# Future phases (separate PRs against this workflow): heartbeat probe,
3131
# macOS permissions probe, pre-tag checklist, rollback runbook.
@@ -42,11 +42,11 @@ name: Smoke test (build + boot)
4242
#
4343
# Cost: $0. Public repo, standard runners. All four matrix entries
4444
# (ubuntu-latest, macos-latest, ubuntu-24.04-arm, windows-latest) are
45-
# free for public repos. Observed timings on this branch:
45+
# free for public repos. Observed timings:
4646
# - linux-x64 ~4 min cold cache
47+
# - linux-arm64 ~5 min cold cache (required gate as of 2026-05-16)
4748
# - darwin-arm64 ~7 min cold cache
48-
# - linux-arm64 not yet measured (first run with this matrix)
49-
# - windows-x64 not yet measured (first run with this matrix)
49+
# - windows-x64 ~8 min cold cache (still experimental β€” see matrix)
5050
# Total wall-clock is bounded by the slowest entry because matrix
5151
# entries run in parallel.
5252

@@ -93,8 +93,7 @@ jobs:
9393
matrix:
9494
include:
9595
# ── Required gates ────────────────────────────────────────────
96-
# These two MUST be green before the launcher is tagged. They
97-
# cover the platforms we ship to users next Wed/Thu. A red
96+
# These MUST be green before the launcher is tagged. A red
9897
# entry here fails the Smoke test summary job and prevents
9998
# release tagging once branch protection is enabled on main.
10099
- os: ubuntu-latest
@@ -103,31 +102,29 @@ jobs:
103102
- os: macos-latest
104103
label: darwin-arm64
105104
experimental: false
105+
# linux-arm64 promoted 2026-05-16 after 5 consecutive green
106+
# runs since A-3 matrix expansion (runs 25947219129,
107+
# 25947614795, 25955832357, 25956072211, 25956409080).
108+
# The Linux ARM build chain has proven identical to x86_64
109+
# under our apt-get + canvas system-libs setup; promoting it
110+
# tightens the safety net for the post-Mac ARM rollout.
111+
- os: ubuntu-24.04-arm
112+
label: linux-arm64
113+
experimental: false
106114

107-
# ── Experimental gates (A-3 matrix expansion) ────────────────
108-
# These two run on every push but are NOT release blockers.
109-
# They surface platform-specific regressions ahead of the
110-
# Linux-ARM / Windows launcher rollout after the Mac release
111-
# ships. continue-on-error: true (set below) means a red entry
112-
# here lands as a yellow advisory on the dashboard rather than
113-
# a red workflow failure.
115+
# ── Experimental gates ───────────────────────────────────────
116+
# Run on every push but NOT release blockers. continue-on-error
117+
# is wired below so a red entry here is a yellow advisory.
114118
#
115-
# Expected initial state:
116-
# - ubuntu-24.04-arm: likely green. Build chain is Unix and
117-
# apt-get canvas libs work the same on arm64. If red,
118-
# diagnose and fix incrementally.
119-
# - windows-latest: likely red on typecheck because canvas@2
120-
# building from source on Windows needs MSVC + GYP +
121-
# non-trivial setup; we explicitly do NOT install canvas
122-
# system libs on Windows in this phase. The Phase 2 canvas
123-
# migration to @napi-rs/canvas removes this entire concern.
119+
# Promotion criterion: 5 consecutive green runs without revert.
124120
#
125-
# Promotion path: once an experimental entry has been green for
126-
# 5 consecutive pushes, flip its `experimental: true` to false
127-
# to make it a required gate.
128-
- os: ubuntu-24.04-arm
129-
label: linux-arm64
130-
experimental: true
121+
# windows-x64 status (2026-05-16): green for the first time on
122+
# run 25956072211 after fixing (a) env-var-prefix syntax via
123+
# cross-env, (b) node --test glob expansion, (c) CRLF in test
124+
# source scanner. Only 1-2 consecutive greens so far; needs
125+
# ~3 more clean runs before promotion. Next potential blocker
126+
# (when investigated): the build:gui cp -r command may need
127+
# cross-platform replacement in Phase 2.
131128
- os: windows-latest
132129
label: windows-x64
133130
experimental: true

0 commit comments

Comments
Β (0)