Skip to content

#754 Multiple Uploads#763

Merged
lprichar merged 10 commits intomainfrom
bug/754-multiple-uploads
Aug 23, 2022
Merged

#754 Multiple Uploads#763
lprichar merged 10 commits intomainfrom
bug/754-multiple-uploads

Conversation

@lprichar
Copy link
Copy Markdown
Contributor

Issue

Fixes #754

Description

This PR attempts several UX enhancements in order to clarify how multiple ballots works. In particular:

  • Renames "Decryption" to "Tally" in the UI. In other words, to decrypt votes and view a tally and spoiled ballots you now create a new Tally rather than creating a Decryption.
  • Excludes duplicate ballots. If you upload the same ballots multiple times the UI will warn you.
  • Displays a sum of ballots uploaded on the election page
  • Shows the number of ballots uploads and the sum of ballots for each tally
  • Replaces the individual buttons with an action button and dropdown menu to show descriptions next to each action

Testing

Go to the election page, it should now look like this:

image

  • Notice "Decryptions" in the bottom left is now called "Tallies"
  • Notice the sum of all successfully uploaded ballots (81) in the bottom left
  • Notice the action button in the top right. If you click it you get this:

image

Notice "Add Tally" not "Add Decryption"

If you try to add ballots multiple times you get this while uploading:

image

And if there were no new ballots you'll get this:

image

Finally, when you create a Tally, it now shows the number of uploads and the number of ballots it contains:

image

@SteveMaier-IRT
Copy link
Copy Markdown
Contributor

On the upload ballot complete screen, we can add another button to allow the user to easily put in another drive and upload more ballots. The existing button can be renamed to something like Done Uploading and it goes back to the election screen and the new button will let them start another upload.

Copy link
Copy Markdown
Contributor

@SteveMaier-IRT SteveMaier-IRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. nice enhancement for usability.

@lprichar lprichar merged commit 3cbbccc into main Aug 23, 2022
@lprichar lprichar deleted the bug/754-multiple-uploads branch August 23, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 Multiple ballot uploads should tally together

2 participants