#768 - System now successfully resumes from sleep on guardian page#771
Merged
#768 - System now successfully resumes from sleep on guardian page#771
Conversation
lprichar
commented
Aug 24, 2022
SteveMaier-IRT
suggested changes
Aug 25, 2022
Contributor
SteveMaier-IRT
left a comment
SteveMaier-IRT
left a comment
There was a problem hiding this comment.
When the admin times out because the tablet was put to sleep using the power button, the UI will not show the existing elections. The console will tell the user to hit ctrl+C to close the egui app, but this does not close the gui at all.
The refresh button on the guardian home page worked well and was able to reconnect from a lost socket.
The admin pages are abit more complex and a solution will be needed from multiple pages, not just the home page like the guardians.
Contributor
Author
|
Great points. Added issue to track remaining work: I will fix the Ctrl+C comment in this PR shortly. |
lprichar
force-pushed
the
bug/768-hibernate
branch
from
2a38ad9 to
f39c5bc
Compare
SteveMaier-IRT
approved these changes
Aug 26, 2022
Contributor
SteveMaier-IRT
left a comment
SteveMaier-IRT
left a comment
There was a problem hiding this comment.
lgtm for the guardian
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #768
Description
The underlying issue was that Eel in Python would die when the system was resuming from sleep. The web-based UI then looked like it was still working when in fact the server had crashed. That gave the appearance of key ceremonies and decryptions not appearing on guardian devices when they should have, when in fact the issue was much larger.
The server-side solution is to disallow eel from ever exiting of its own accord. This allows eel to resume from system sleep, although it has the consequence that the user must now explicitly hit Ctrl+C to end the app.
The client-side solution is to watch for system resume events and when they occur refresh the page. This solution also adds a refresh button for convenience, although the prior solutions should warrant it unnecessary.
Testing
Expected the guardian should see the new key ceremony on their home page