Skip to content

#766 Ballot Enhancements#774

Merged
lprichar merged 9 commits intomainfrom
bug/766-ballot-enhancements
Aug 26, 2022
Merged

#766 Ballot Enhancements#774
lprichar merged 9 commits intomainfrom
bug/766-ballot-enhancements

Conversation

@lprichar
Copy link
Copy Markdown
Contributor

Issue

Fixes #766

Description

Primarily this adds additional validation during ballot upload that the ballots match the manifest. It also:

  • Fixes an issue where error messages weren't displayed correctly on the decryption page
  • Improves the UI of the election page
    • Moves buttons on the menu to appropriate sections where possible
    • Displays a nice message if there aren't any ballots and tallies
    • Moves the title down and separates the sections more clearly
    • Updates button colors from green to gray
    • Move title lower on page and adjusts spacing
    • Add tally date to tallies list
    • Add upload date to ballots list
  • Improves the UI of the decryption page
    • Adjusts UI to match election page e.g. buttons to grey
    • Renames "Decryption Results" to "Tally Results"
    • Moves spoiled ballots into a table
    • Show a nice message if no spoiled ballots exist

Testing

Try uploading a ballot that belongs to a different manifest, it should now show like this:

image

A bran new election with no ballots uploaded looks like this:

image

An election with a few ballot uploads and a tally now looks like this:

image

Move buttons on menu to appropriate sections where possible
Display ballots and tallies even when there isn't information to display
Move the title down and separate the sections more clearly
Button color -> secondary
Move title lower on page
Decryption Results -> Tally Results
Show a nice message if no spoiled ballots existed
@lprichar lprichar force-pushed the bug/766-ballot-enhancements branch from 447de8a to 718b4f7 Compare August 26, 2022 17:05
Copy link
Copy Markdown
Contributor

@SteveMaier-IRT SteveMaier-IRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lprichar lprichar merged commit da4fd4b into main Aug 26, 2022
@lprichar lprichar deleted the bug/766-ballot-enhancements branch August 26, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 Upload Ballots Enhancements

2 participants