fix(tally): fix shared default ciphertext in tally selection#810
Open
mdevolde wants to merge 1 commit intoElection-Tech-Initiative:mainfrom
Open
fix(tally): fix shared default ciphertext in tally selection#810mdevolde wants to merge 1 commit intoElection-Tech-Initiative:mainfrom
mdevolde wants to merge 1 commit intoElection-Tech-Initiative:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #809
Description
This change updates
CiphertextTallySelection.ciphertextto usedefault_factoryinstead of a sharedElGamalCiphertextinstance as a dataclass field default. That ensures eachCiphertextTallySelectiongets its own ciphertext value rather than sharing the same default object across instances.The behavior avoids unintended shared state if the default ciphertext is ever mutated in place, and also resolves the dataclass validation error raised by Python 3.11 for mutable defaults.
I ran the tests locally:
poetry run pytest tests/unit,poetry run pytest tests/property,poetry run pytest tests/integration(on python 3.9.21, on windows 11). I built the project withpoetry buildon the same environment.Testing
Run the relevant tally-related test suites with:
These validate that
CiphertextTallySelectionstill behaves correctly.