Adds new command line parameters to 'electronize build' #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 28, 2019 14:41
…path, and allowing specification of a package.json file to use.
Collaborator
|
@GregorBiswanger Didn't you implement something with the custom package.json? Is this merged to master? |
added 2 commits
March 28, 2019 15:45
…luded with source.
skipping due to an existing node_modules folder. This is also implicitly triggered by providing your own package.json file. This ensures that the actual packages match the package.json.
Contributor
Author
|
Thanks @robertmuehsig! Happy to answer any questions here about my changes. |
gfs
changed the title
|
This works with |
Contributor
Author
|
I don't believe that this PR added this functionality to the start command. Just build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227.
electronize buildallowing users to specify the output path, and to provide their own package.json and to specify that they want annpm install/package-jsonspecifies a package.json file the user wishes to use, and sets/install-modules/install-modulesspecifies thatelectronize buildshould alwaysnpm install/relative-pathspecifies a relative path to output binaries/absolute-pathspecifies an absolute path to output binaries.buildReleaseNuGetPackages.cmdscript.Package.jsonto match the license included in the code (ISC -> MIT)The path specifications change the path provided to
electron-packager.The
package-jsonargument overwrites the bundled package.json after laying out the pre-packed files.I've tested all four commands manually.
I have noticed you have to be very careful to match your custom package.json with the auto deployed package.json. So documentation for these commands should note that. My procedure was to layout the files normally and then edit the package.json setting it aside to provide as an argument.
Update:
After additional work added one more command line parameter.