Skip to content

Should never use async void #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertmuehsig merged 1 commit into from
Nov 4, 2017
Merged

Should never use async void #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public static IWebHost BuildWebHost(string[] args)
Open the Electron Window in the Startup.cs file:

```csharp
public async void Configure(IApplicationBuilder app, IHostingEnvironment env)
public void Configure(IApplicationBuilder app, IHostingEnvironment env)
{
if (env.IsDevelopment())
{
Expand All @@ -60,7 +60,7 @@ public async void Configure(IApplicationBuilder app, IHostingEnvironment env)
});

// Open the Electron-Window here
await Electron.WindowManager.CreateWindowAsync();
Task.Run(async () => await Electron.WindowManager.CreateWindowAsync());
}
```

Expand Down