Handle missing /target argument for build command.
#342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregorBiswanger
assigned
robertmuehsig and
GregorBiswanger and unassigned
robertmuehsig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this myself today, if a user fails to provide the
/targetargument when runningelectronize buildthey simply get aKeyNotFoundException.This change checks for the presence of this argument and, if not present, displays help information to the user as well as gracefully exiting.
Related to #296
As a sidenote, is there a reason we don't use a command line parsing library (for example - https://github.com/commandlineparser/commandline) to handle these cases for us?