Skip to content

Conversation

@NimbusFox
Copy link

Removed the unneeded serializer and applied the settings to the global this._jsonSerializer as when the X and Y values are -1 in the options it would lead to some settings not being applied. E.g. ContextIsolation with it now applying the default values when serializing, settings mentioned before are correctly assigned on Electron's end

In regards to #906

Removed the unneeded serializer and applied the settings to the global
this._jsonSerializer as when the X and Y values are -1 in the options
it would lead to some settings not being applied. E.g. ContextIsolation
with it now applying the default values when serializing, settings
mentioned before are correctly assigned on Electron's end
Copy link
Collaborator

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Any idea why we might have needed / used the previous behavior on the _jsonSerializer @GregorBiswanger ?

@FlorianRappl FlorianRappl changed the base branch from main to develop November 6, 2025 18:57
@FlorianRappl
Copy link
Collaborator

(Wrong base branch used - I changed the target to develop, but that has no impact on the actions, i.e., it does not re-trigger the actions to run)

@softworkz
Copy link
Contributor

Any idea why we might have needed / used the previous behavior on the _jsonSerializer @GregorBiswanger ?

The earlier SocketIO libraries didn't have built-in serialization.

@FlorianRappl
Copy link
Collaborator

The earlier SocketIO libraries didn't have built-in serialization.

Yes, but why was the behavior set to DefaultValueHandling.Ignore?

@softworkz
Copy link
Contributor

softworkz commented Nov 6, 2025

The earlier SocketIO libraries didn't have built-in serialization.

Yes, but why was the behavior set to DefaultValueHandling.Ignore?

Typically it would be about reducing payloads, but

  • that's not really a concern on local loopback networking
  • it's not valid to do so across language boundaries, because the JS side will unlikely have the same default values (usually none at all)

@FlorianRappl FlorianRappl merged commit 98d085f into ElectronNET:develop Nov 7, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants