Skip to content

Conversation

@Denny09310
Copy link

I'm not very familiar with the codebase yet, especially since I still need to go through all the TS/JS parts. While looking at the develop branch (the one without the migration to System.Text.Json), I added some comments to point out what isn't working in the demo. I figured that if someone with more experience in the codebase is interested, they could help fix those issues, so we can have a solid base to work from when attempting the migration in the future.

@Denny09310
Copy link
Author

This where quick findings, I'll try debug them later

return;
}

// FIXME: At launch the newState is 'Started' and this.state is 'Ready' throwing always an error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed here: 9c1b688

{
if(HybridSupport.IsElectronActive)
{
// FIXME: System.TimeoutException: 'No response after 1000ms trying to retrieve value app.GetAppPathAsync()'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed by this: #913

Electron.AutoUpdater.OnUpdateDownloaded += async (info) => await Electron.Dialog.ShowMessageBoxAsync("Update complete!" + info.Version);


// FIXME: System.TimeoutException: 'No response after 1000ms trying to retrieve value app.GetVersionAsync()'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed here: #913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants