ElectronNET.API: Add platform support attributes #929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softworkz
force-pushed
the
submit_platform_annotations
branch
from
75b9e85 to
72839eb
Compare
Collaborator
Author
|
This is insane - the page is hardly navigatable anymore. 
Maybe you have permission: when you cliick on the 3-dot button, you should see "Hide" and next choose "Spam". Then it all goes away instantly.... |
softworkz
force-pushed
the
submit_platform_annotations
branch
3 times, most recently
from
f7b2cb6 to
2334eff
Compare
Collaborator
Author
|
Okay, I've rebased this, but now it's failing due to that: #932 (comment) |
Collaborator
Author
|
This happens due to the tests not having platform attributes yet. When the test-update PR is merged, then this one will become green again 🤣 |
softworkz
force-pushed
the
submit_platform_annotations
branch
from
2334eff to
0580942
Compare
Collaborator
Author
|
Rebased this one, let's see... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The procedure for this was.
###(drops model object properties