Webb app: add platform guards and promote analyzer severity #932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds platform-specific guards to prevent calling macOS/Windows-only Electron APIs on unsupported platforms and promotes the CA1416 analyzer (platform compatibility) to error severity to enforce these checks at compile time.
Key changes:
- Wraps
Electron.Dock.SetMenuwithIsMacOS()guard in Program.cs - Wraps PowerMonitor event subscriptions with
IsMacOS() || IsWindows()guard in HomeController.cs - Adds .editorconfig to promote CA1416 to error severity
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/.editorconfig | Promotes CA1416 (platform compatibility) analyzer to error severity for all C# files |
| src/ElectronNET.WebApp/Program.cs | Adds macOS guard around Dock API usage |
| src/ElectronNET.WebApp/Controllers/HomeController.cs | Adds macOS/Windows guard around PowerMonitor event subscriptions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
Ouch...
(but well - only until the others are merged...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged last, otherwise it would cause errors