fix: socket.connnect JS : Scope & Closures #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: io.reconnect socket Closure
robertmuehsig
requested changes
Feb 19, 2018
| <TargetFramework>netcoreapp2.0</TargetFramework> | ||
| <AssemblyName>dotnet-electronize</AssemblyName> | ||
|
|
||
| <PackageType>DotnetCliTool</PackageType> |
Collaborator
There was a problem hiding this comment.
Be aware: This is needed and should not be deleted!
| This package contains the dotnet tooling to electronize your application.</Description> | ||
| <PackageLicenseUrl>https://github.com/ElectronNET/Electron.NET/blob/master/LICENSE</PackageLicenseUrl> | ||
| <PackageProjectUrl>https://github.com/ElectronNET/Electron.NET/</PackageProjectUrl> | ||
| <RepositoryUrl>https://github.com/ElectronNET/Electron.NET/</RepositoryUrl> |
Collaborator
There was a problem hiding this comment.
Shouldn't be deleted as well
Collaborator
|
Hi @mojinxun |
Contributor
Author
|
ok， I create nuget, something error, so I delete it |
Contributor
Author
|
I update it, please review it |
Collaborator
|
@GregorBiswanger Please take a look. |
do: io.setMaxListeners(0);
Collaborator
|
@GregorBiswanger What about this PR? |
added 11 commits
May 7, 2018 17:18
2. IpcMain add off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when io reconnect, a new socket well create.
but from front socket not be updated
the commit is fix it by global.elesocket
please check, or better method