-
-
Notifications
You must be signed in to change notification settings - Fork 745
Fix publishing documentation #965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the MSBuild publish profile examples in the package building documentation to use the correct property names and structure for modern .NET publishing.
- Updates obsolete MSBuild property names (e.g.,
PublishDir→PublishUrl,PublishProtocol→PublishProvider) - Adds missing publish profile properties (
DeleteExistingFiles,WebPublishMethod,_TargetId,ProjectGuid) - Removes unnecessary properties from ASP.NET publish profiles (
Configuration,Platform,PublishSingleFile)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Just a few notes from my testing with publish profiles:
|
Probably not, but I'm not sure about it. There is surely some reason why the publishing wizard adds it.
This doesn't work when there's no |
Fair point; my point is that the publish profile itself doesn't work if no |
fab4b84 to
42604ef
Compare
|
You are absolutely right: Configuration and Platform must be present. I've updated this PR, thanks! |
|
This is included in the other PR now: #966 |
No description provided.