-
-
Notifications
You must be signed in to change notification settings - Fork 746
Combine and separate workflows #977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine and separate workflows #977
Conversation
softworkz
commented
Dec 12, 2025
- Separate between PR and Push execution (with and without secrets)
- Turn tests into re-usable workflows and call them from the main ones
- Introduce a random delay to avoid "npm gateway timeout errors"
- Add a workflow to re-run failed test jobs
- Separate between PR and Push execution (with and without secrets) - Turn tests into re-usable workflows and call them from the main ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR restructures the GitHub Actions workflows to separate PR validation from push/publish workflows, implements reusable workflow patterns, and adds automatic retry logic for flaky tests.
Key Changes:
- Split CI workflow into separate "PR Validation" and "Build and Publish" workflows with appropriate secret handling
- Converted integration tests and whitespace checks into reusable workflows called by main workflows
- Added automatic retry mechanism for failed integration test matrix jobs
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ElectronNET.sln | Updated workflow file references to reflect new workflow names |
| .github/workflows/trailing-whitespace-check.yml | Converted to reusable workflow with workflow_call trigger |
| .github/workflows/retry-test-jobs.yml | New workflow to automatically rerun failed integration test jobs |
| .github/workflows/pr-comment.yml | Updated to reference renamed "PR Validation" workflow |
| .github/workflows/integration-tests.yml | Converted to reusable workflow and added random delay to prevent npm timeouts |
| .github/workflows/ci.yml | Renamed to "Build and Publish" and restructured to use reusable workflows |
| .github/workflows/PR Validation.yml | New workflow for PR validation that orchestrates whitespace checks, tests, and build |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
FlorianRappl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great one! I'm not sure the delay fixes the issue, but it also can't hurt.
|
I forgot to mention that I made this direct commit yesterday 33da428 - I don't want to do that normally, but it seemed trivial enough in that case. |
