Skip to content

Remove typings/typing-tests from npm package#372

Merged
e1emeb0t merged 2 commits intoElemeFE:masterfrom
f48vj:fix/npmignore
May 16, 2017
Merged

Remove typings/typing-tests from npm package#372
e1emeb0t merged 2 commits intoElemeFE:masterfrom
f48vj:fix/npmignore

Conversation

@f48vj
Copy link
Contributor

@f48vj f48vj commented May 16, 2017

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • Rebase your commits to make your pull request meaningful.
  • Make sure that your changes pass npm test, npm run lint and npm run build.

Changes in this pull request

  • Remove typings/typing-tests from npm package

e1emeb0t
e1emeb0t approved these changes May 16, 2017
View reviewed changes
Copy link
Contributor

@e1emeb0t e1emeb0t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🍺

@e1emeb0t e1emeb0t merged commit 08472ba into ElemeFE:master May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@e1emeb0t e1emeb0t e1emeb0t approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@f48vj @e1emeb0t