Fixed reactivity of colors prop for rate component#6872
Merged
Leopoldthecoder merged 3 commits intoElemeFE:devfrom Sep 6, 2017
Merged
Fixed reactivity of colors prop for rate component#6872Leopoldthecoder merged 3 commits intoElemeFE:devfrom
Leopoldthecoder merged 3 commits intoElemeFE:devfrom
Conversation
Leopoldthecoder
approved these changes
Sep 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.What I wanted is to allow user to rate some items and also see other users's average rating. Until user rates the item herself that average rating should be "muted" (dimmed colors), so I wanted to pass
colorsprop. However, I then noticed that changing thatcolorsarray at parent component have no impact on the colors at rate component. Looking at the code I can see thatcolorMapis prepared once at thecreatedhook. This makescolorsprop non-reactive which is odd.I've made
colorMapa computed value that should be based oncolorsprop.