Skip to content

Dropdown: Click open uses show-timeout attribute#8734

Merged
Leopoldthecoder merged 3 commits intoElemeFE:devfrom
presidenten:dev
Dec 10, 2017
Merged

Dropdown: Click open uses show-timeout attribute#8734
Leopoldthecoder merged 3 commits intoElemeFE:devfrom
presidenten:dev

Conversation

@presidenten
Copy link
Copy Markdown
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • [x ] Make sure you follow Element's contributing guide (中文 | English | Español).
  • [x ] Make sure you are merging your commits to dev branch.
  • [x ] Add some descriptions and refer relative issues for you PR.

Click to open dropdown ignored the show-timeout attribute.
Rewrote the click handler to use open/close methods instead of manipulating visible directly.

If possible, please release a new patch version with this fix as soon as possible.

Thanks

@presidenten presidenten closed this Dec 8, 2017
@presidenten
Copy link
Copy Markdown
Contributor Author

Ill reopen once I fix the tests

@presidenten presidenten reopened this Dec 8, 2017
@presidenten presidenten closed this Dec 8, 2017
@presidenten presidenten reopened this Dec 8, 2017
@presidenten
Copy link
Copy Markdown
Contributor Author

Fixed the failing test

@Leopoldthecoder Leopoldthecoder merged commit 8ae2def into ElemeFE:dev Dec 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants